New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes issue #9 - added unique event name "showandtell" #10
Conversation
- updated tests (children.js still shows issues)
This looks pretty good. Are the tests still passing? I think I might prefer the events to be namespaced, eg. Thanks for taking the time to make a PR :-) |
All tests are passing but i can't get As for the namespaced event name, i initialy opted towards this solution but i found some issues with it like: https://stackoverflow.com/questions/4718841/namespaced-custom-events-trigger Maybe i should just try it out, perhaps this issue isn't there anymore. |
Fair, let's go with the model for event naming you have implemented for now. What output is children.js giving you? |
Oh! I think maybe children.js never worked, so you're ok leaving it broken :-) (I know this is really bad practice, but it is as-yet unfixed...) |
I will just merge your code :-) |
Side note: i've tested namespace events with jQuery 2.1.4 and jQuery 3.0, seems to work properly, so the stackoverflow issue does not exist anymore. |
Another side note: the |
Cool. I think maybe we should go for the namespaced events before we make a release, if there aren't any issues with them? What do you say? |
... and updated tests (children.js still shows issues)
see issue #9