Allow SASL UID to be provided via the TransportBuilder
#178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eing detected. There are a couple of reasons for this PR. 1. I have an SSH transport. If I am using SASL, and if I am connecting from a machine where the local user UID differs from the authenticated user on the remote machine, the DBus connection will not be allowed. We must pretend that our UID is that of the remote user. I do not see this as security issue, the user is already authenticated by SSH, and the broker is validating that the connection is coming from the remote user. 2. The use of `UnixSystem` breaks when attempting to compile to native code with GraalVM (actually, it fails to link). I believe this is a bug in Graal, but neverthless `UnixSystem` is not part of the official API and is platform dependent. This is the sole reason for depending on the `jdk.security.auth` module. Usage :- `builder.transportConfig().withSaslUid(1000);`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.. instead of being detected.
There are a couple of reasons for this PR.
I have an SSH transport. If I am using SASL, and if I am connecting from a machine where the local user UID differs from the authenticated user on the remote machine, the DBus connection will not be allowed. We must pretend that our UID is that of the remote user. I do not see this as security issue, the user is already authenticated by SSH, and the broker is validating that the connection is coming from the remote user.
The use of
UnixSystembreaks when attempting to compile to native code with GraalVM (actually, it fails to link). I believe this is a bug in Graal, but neverthelessUnixSystemis not part of the official API and is platform dependent. This is the sole reason for depending on thejdk.security.authmodule.Usage :-
builder.transportConfig().withSaslUid(1000);