Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added trace to functions and check helper #83

Merged
merged 2 commits into from
Jun 7, 2021
Merged

Added trace to functions and check helper #83

merged 2 commits into from
Jun 7, 2021

Conversation

Gerard097
Copy link
Collaborator

@Gerard097 Gerard097 commented May 24, 2021 •
edited

  • Added macro to Trace functions
  • Replaced eosio::check with custom EOS_CHECK to enable more information about the error

@Gerard097 Gerard097 requested a review from mgravitt May 24, 2021 16:44
@josejulio
Copy link
Contributor

This looks cool, but not a fan of having to add the function manually on every call, perhaps we could use this? https://stackoverflow.com/a/5081403/688379

josejulio
josejulio approved these changes May 26, 2021
View reviewed changes
Copy link
Contributor

@josejulio josejulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, an awesome idea to get a better idea of what is failing.

@leonieherma1 leonieherma1 added this to Ready for Dev in Hypha DHO Jun 3, 2021
@mgravitt mgravitt merged commit 53c13d4 into develop Jun 7, 2021
@mgravitt mgravitt deleted the feature/logger branch June 7, 2021 15:22
@leonieherma1 leonieherma1 moved this from Up Next to Needs Design/Specifications in Hypha DHO Aug 26, 2021
@leonieherma1
Copy link

@Gerard097 the last update is from May, can this be closed?

@Gerard097
Copy link
Collaborator Author

@Gerard097 the last update is from May, can this be closed?

Yep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josejulio josejulio josejulio approved these changes

@mgravitt mgravitt Awaiting requested review from mgravitt

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Hypha DHO
  
Needs Design/Specifications
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Gerard097 @josejulio @leonieherma1 @mgravitt