v1 Setup#31
Merged
Merged
Conversation
|
Do ping me for reviewing :) |
RangerMauve
suggested changes
Nov 30, 2022
RangerMauve
left a comment
Contributor
There was a problem hiding this comment.
Great progress! I think the general structure is exactly what we need. 👍
Just left a few comments on some details that could be changed.
Co-authored-by: RangerMauve <RangerMauve@hotmail.com>
Contributor
|
Jacky is figuring out the typescript issues with the promethius logger, and we'll create a new issue for it and merge what we have for the project structure so far so that Fauno and others can run the server stubs to start |
5 tasks
RangerMauve
suggested changes
Dec 5, 2022
Collaborator
|
Just to note the build breaks if you're using pnpm, I think it's because you need to add this dependency explicitly |
Collaborator
|
|
Collaborator
|
openapi-generator-cli said: |
Collaborator
doesn't happen with swagger-codegen-cli |
RangerMauve
approved these changes
Dec 6, 2022
RangerMauve
left a comment
Contributor
There was a problem hiding this comment.
Feel free to merge this 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes hyphacoop/distributed-press-organizing#57