Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement random sort and dynamic timeline sorting via dropdown #13

Merged
merged 10 commits into from
Jun 5, 2024

Conversation

akhileshthite
Copy link
Collaborator

@akhileshthite akhileshthite commented May 9, 2024

@akhileshthite akhileshthite self-assigned this May 9, 2024
@akhileshthite akhileshthite added the enhancement New feature or request label May 9, 2024
@akhileshthite akhileshthite changed the title Implement random sort and dynamic timeline sorting via dropdown feat: implement random sort and dynamic timeline sorting via dropdown May 9, 2024
Base automatically changed from initial to main May 10, 2024 11:14
Copy link
Contributor

@RangerMauve RangerMauve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, good work on the initial pass.

I think we could have a cleaner hasMore logic by having the reader track the current count vs how many items total are in the notes collection.

Also instead of storing notes in an array we should render them out as we get them. For duplicates, we can just not bother tracking duplicate notes when rendering the randomized timeline.

Also, we should start doing a page render before ingesting followed accounts to improve initial load.

db.js Outdated Show resolved Hide resolved
db.js Outdated Show resolved Hide resolved
index.html Show resolved Hide resolved
timeline.js Outdated Show resolved Hide resolved
db.js Outdated Show resolved Hide resolved
db.js Show resolved Hide resolved
timeline.js Outdated Show resolved Hide resolved
db.js Outdated Show resolved Hide resolved
db.js Outdated Show resolved Hide resolved
timeline.js Outdated Show resolved Hide resolved
Copy link
Contributor

@RangerMauve RangerMauve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! :)

@RangerMauve RangerMauve merged commit 192b27f into main Jun 5, 2024
1 check passed
@RangerMauve RangerMauve deleted the timelines branch June 5, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants