Add AUTHORIZED_FETCH disclaimer to Actor Profile error messages #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
akhileshthite
commented
May 14, 2024
akhileshthite
commented
akhileshthite
commented
May 14, 2024
| @@ -170,6 +170,7 @@ class DistributedActivity extends HTMLElement { | |||
| displayUnimplemented () { | |||
| const message = `Activity type ${this.activityType} is not implemented yet.` | |||
| const messageElement = document.createElement('p') | |||
| messageElement.classList.add('other-activity') | |||
akhileshthite
commented
May 16, 2024
profile.html
Outdated
| nextButton.addEventListener("click", () => outboxElement.nextPage()); | ||
| } | ||
| document.addEventListener('usernameUpdated', (event) => { | ||
| document.title = `@${event.detail.username}`; |
akhileshthite
commented
May 16, 2024
| select.appendChild(standardGroup) | ||
|
|
||
| // Create and append the colorblind theme options within an optgroup | ||
| const colorBlindGroup = document.createElement('optgroup') |
RangerMauve
requested changes
May 16, 2024
| pUserName.classList.add('profile-username') | ||
| pUserName.href = db.getObjectPage(actorInfo) |
There was a problem hiding this comment.
Why was this removed? Could we add it back? I find it useful to be able to navigate to accounts on their native web url.
There was a problem hiding this comment.
Added back.
It was a mistake.
profile.html
Outdated
| nextButton.addEventListener("click", () => outboxElement.nextPage()); | ||
| } | ||
| document.addEventListener('usernameUpdated', (event) => { | ||
| document.title = `@${event.detail.username}`; |
There was a problem hiding this comment.
Instead of replacing can we do a += so we can still identify the tab as being part of the social reader?
RangerMauve
requested changes
May 22, 2024
This was referenced Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.