Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes remote instances require all requests to be signed #16

Closed
fauno opened this issue Sep 18, 2023 · 6 comments
Closed

Sometimes remote instances require all requests to be signed #16

fauno opened this issue Sep 18, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@fauno
Copy link
Collaborator

fauno commented Sep 18, 2023

(We're asking the instance admin if we can name it publically)

We're testing remote follows from a Mastodon+Glitch v4.1.3 instance and it fails because it requires signed requests to fetch Actors. We can reproduce by curling the follower profile:

curl --header "Accept: application/activity+json" FOLLOWER_PROFILE_URL | jq .

Returns:

{
  "error": "Request not signed"
}
@fauno
Copy link
Collaborator Author

fauno commented Sep 18, 2023

@fauno
Copy link
Collaborator Author

fauno commented Oct 12, 2023

Action: All requests should be signed, or feature detection is needed to discover which instances require signed requests

@RangerMauve
Copy link
Contributor

Cool, yes that is very doable.

@RangerMauve RangerMauve added the enhancement New feature or request label Nov 7, 2023
@RangerMauve
Copy link
Contributor

RangerMauve commented Nov 7, 2023

@akhileshthite Basically we need to replace the call to this.fetch with this.signedFetch

https://github.com/hyphacoop/social.distributed.press/blob/initial/src/server/apsystem.ts#L187

@akhileshthite
Copy link
Collaborator

akhileshthite commented Nov 8, 2023

@akhileshthite Basically we need to replace the call to this.fetch with this.signedFetch

https://github.com/hyphacoop/social.distributed.press/blob/initial/src/server/apsystem.ts#L187

Do we need a test named getActor fetches and returns the actor profile using signedFetch for this?

RangerMauve added a commit that referenced this issue Nov 14, 2023
 feat: remote instances require all requests to be signed (#16)
@RangerMauve
Copy link
Contributor

Merged into latest initial branch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants