Paginated inbox

[fauno]

Nula and/or Agus to work on this. They should do an estimate for this task and let us know, so we an put it in the roadmap

Just an idea we can discuss later. I don't remember now if the inbox could be paginated, but if it is, the first page could always be pending activities and later pages activities that have been approved (and can be rejected at any time)

[RangerMauve]

Yeah also depends on #152

[fauno]

Pagination is important because if the JSONLD object grows too much we'll hit response limits. If we keep pending activities on the first page you could be DDOSed by just receiving too many activities. Maybe always paginate and have another collection for pending activities, so it's also explicit.

[RangerMauve]

• modify the activtystore
• add a new sublevel for indexes
• add a new sublevel on the indexes for published
• when adding a new actvity, use the published time+the id as the key and the id as the value
• when deleting an activity generate the publish key and delete it from the sublevel in addition to deleting the activity
• modify list to iterate from the published sublevel and get activities by id
• add skip, limit, and sort fields to list
• add skip limit and sort fields to the outbox querystring
• by default don't have the items in the outbox but instead link to a next page with the skip set to 0 and a limit set to some default (e.g. 128)
• when rendering a page, have a prev field which reduces the skip field by the limit
• we should add a count to the activitystore which fetches the total size from the activities collection, and add the total items field

[fauno]

@RangerMauve does this mean we can paginate the inbox via url params? also for fetching approved or pending separately?

[RangerMauve]

We don't have approved or not tracked yet but we could add that as a next step for indexing if that'd help.

[catdevnull]

hey @RangerMauve, i'm not fully understanding this part:

when deleting an activity generate the publish key and delete it from the sublevel in addition to deleting the activity

what does it mean to delete an activity? in general, can you reexplain this point?

[RangerMauve]

Ah by "deleting an activity" I just meant to add some code inside ActvityStore#remove here: https://github.com/hyphacoop/social.distributed.press/blob/main/src/server/store/ActivityStore.ts#L25

In addition to deleting the activity from the store we also need to clean up any indexes referencing it.

[RangerMauve]

Generally whenever you add any data to a store you should have an api for removing the data from it.

[sutty-coop]

We need to add tests - @RangerMauve could take this on