Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paginated inbox #63

Merged
merged 7 commits into from
Jun 4, 2024
Merged

paginated inbox #63

merged 7 commits into from
Jun 4, 2024

Conversation

catdevnull
Copy link
Contributor

@catdevnull catdevnull commented May 16, 2024

fixes hyphacoop/distributed-press-organizing#163

  • add some way to automatically add indexes to existing inboxes

@catdevnull catdevnull marked this pull request as ready for review May 21, 2024 19:41
Copy link
Contributor

@RangerMauve RangerMauve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start, mind also adding a test to make sure that stuff is sorted?

  • create fake posts
  • have their id be incrementing (a,b,c) but their publish time decrementing (3,2,1)
  • do a list and check that the order is correct
  • also test with limit=1 and skipping.

src/server/api/inbox.ts Outdated Show resolved Hide resolved
src/server/store/ActivityStore.ts Outdated Show resolved Hide resolved
src/server/store/ActivityStore.ts Outdated Show resolved Hide resolved
src/server/store/ActivityStore.ts Outdated Show resolved Hide resolved
src/server/store/ActivityStore.ts Show resolved Hide resolved
src/server/store/ActivityStore.ts Show resolved Hide resolved
Copy link
Contributor

@RangerMauve RangerMauve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Lets just get some small tests in to make sure it's working and then it looks good to me. :)

src/server/store/ActivityStore.ts Show resolved Hide resolved
@RangerMauve RangerMauve merged commit e837e5b into hyphacoop:main Jun 4, 2024
1 check passed
@catdevnull catdevnull deleted the paginated-inbox branch June 27, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paginated inbox
2 participants