-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
paginated inbox #63
paginated inbox #63
Conversation
Co-authored-by: Agus <magush27@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start, mind also adding a test to make sure that stuff is sorted?
- create fake posts
- have their id be incrementing (a,b,c) but their publish time decrementing (3,2,1)
- do a list and check that the order is correct
- also test with
limit=1
and skipping.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Lets just get some small tests in to make sure it's working and then it looks good to me. :)
fixes hyphacoop/distributed-press-organizing#163