Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hook names are case-sensitive #44

Merged
merged 2 commits into from
Feb 21, 2024
Merged

fix: hook names are case-sensitive #44

merged 2 commits into from
Feb 21, 2024

Conversation

fauno
Copy link
Collaborator

@fauno fauno commented Feb 19, 2024

Hooks weren't running because their key is case-sensitive

@fauno fauno added the bug Something isn't working label Feb 19, 2024
Copy link
Collaborator

@akhileshthite akhileshthite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@akhileshthite
Copy link
Collaborator

@RangerMauve ready to merge?

Copy link
Contributor

@RangerMauve RangerMauve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, gonna deploy to staging this week.

@RangerMauve
Copy link
Contributor

Just to confirm, does this affect the #30 tests?

@RangerMauve RangerMauve merged commit b038d34 into main Feb 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants