-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support undo activities, dont remove accepted inbox items #47
Conversation
RangerMauve
commented
Feb 22, 2024
- fixed a bug where rejected follows were actually accepted
- accepted activities no longer get removed
- added code path for Undo activities
- checks that the same author that made the activity made the undo activity
- removes the activity from the inbox
- if it was a follow request, removes it.
not familiar with the ActivityPub stuff but otherwise looks good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Do we need to have tests for this in apsytem.test.ts; performUndo removes activity and follower for a Follow activity
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my expectation was for the undo/delete activities to remove the activity they reference, are always honored, so they aren't stored on the inbox for approval/rejection (ie. i don't approve you removing a reply).
but webhooks need to be notified in case i already did something with the activity. in the moderation queue we're storing activities with different states, so if someone undoes/deletes an activity, the moderation queue needs to be notified to change its state.
this seems to be the case because the onapproved hook is dispatched, but auto-approval is required to work properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!