Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement store apis #6

Merged
merged 7 commits into from
Aug 30, 2023
Merged

feat: implement store apis #6

merged 7 commits into from
Aug 30, 2023

Conversation

akhileshthite
Copy link
Collaborator

@akhileshthite akhileshthite commented Aug 27, 2023 •
edited
Loading

hyphacoop/distributed-press-organizing#90

  • Implement store apis
  • Split each store class into different files for maintainability
  • Add basic tests to add/remove data from all the store types
    • AccountListStore.test.ts
    • ActivityStore.test.ts
  • Add test to make sure the forActor method properly caches data

@RangerMauve RangerMauve changed the base branch from initial to inbox-flow August 27, 2023 23:10
@RangerMauve RangerMauve marked this pull request as ready for review August 28, 2023 00:29
RangerMauve
RangerMauve approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@RangerMauve RangerMauve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, ty.

@RangerMauve RangerMauve merged commit 681109d into inbox-flow Aug 30, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RangerMauve RangerMauve RangerMauve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@akhileshthite @RangerMauve