Improve tests in the freenet.client package
#826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer version of junit has some enhancements. https://github.com/junit-team/junit4/blob/HEAD/doc/ReleaseNotes4.13.md One of the needed things is the assertThrows() method, which helps to improve try-catch blocks from the test code. https://junit.org/junit4/javadoc/latest/org/junit/Assert.html#assertThrows(java.lang.Class,%20org.junit.function.ThrowingRunnable) Some improvements are required in the tests code. This update is a minor preparation for this work. Signed-off-by: Veniamin Fernandes <veniamin.fernandes@proton.me>
jcenter() repo was closed by the jfrog company and operates in the read-only mode. Gradle is also planning to deprecate this in the future releases. For details see: https://blog.gradle.org/jcenter-shutdown All used lib dependencies seem to be available from the mavenCentral() as well. Signed-off-by: Veniamin Fernandes <veniamin.fernandes@proton.me>
Signed-off-by: Veniamin Fernandes <veniamin.fernandes@proton.me>
Signed-off-by: Veniamin Fernandes <veniamin.fernandes@proton.me>
remove duplication reformat fix assertion methods Signed-off-by: Veniamin Fernandes <veniamin.fernandes@proton.me>
wrap input/output streams with try-with-resources remove duplication use better assertion methods create helper utility ResourceFileUtil Signed-off-by: Veniamin Fernandes <veniamin.fernandes@proton.me>
Bombe
reviewed
Jan 27, 2023
* split try-with-resouces block in FailureCodeTrackerTest.getStoredLength * simplify ResourceFileUtil usage * improve code formatting Signed-off-by: Veniamin Fernandes <veniamin.fernandes@proton.me>
Bombe
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve tests in the
freenet.clientpackageDepends on #822 and #824
Adds improvements to the tests in the
freenet.clientpackage: