Replace charset string parameters with constants from StandardCharsets
#836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove unused private field with type Random from DatabaseKey class. Remove some unused methods from tests. Signed-off-by: Veniamin Fernandes <veniamin.fernandes@proton.me>
venfernand
commented
Apr 21, 2023
Bombe
requested changes
Sep 9, 2023
Also removes stacktrace printout and exception suppression. This slightly changes behavior, but exceptions are not silenced anymore.
Note: I changed only places mentioned in the review comments. Some better and massive tabs-vs-spaces fix is required to solve all other issues.
Bombe
reviewed
Oct 8, 2023
Bombe
reviewed
Oct 8, 2023
…gnature Checked UnsupportedEncodingException cannot be removed because of backward compatibility.
Bombe
approved these changes
Oct 15, 2023
Juiceman
pushed a commit
to Juiceman/fred
that referenced
this pull request
Feb 8, 2024
Note: I changed only places mentioned in the review comments. Some better and massive tabs-vs-spaces fix is required to solve all other issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace charset string parameters with constants from
StandardCharsets.Also remove unused private field with type Random from DatabaseKey class.
Remove some unused methods from tests.