Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for replicated repos #121

Closed
bashims opened this issue Sep 25, 2020 · 3 comments
Closed

add support for replicated repos #121

bashims opened this issue Sep 25, 2020 · 3 comments
Labels
Milestone

Comments

@bashims
Copy link
Contributor

bashims commented Sep 25, 2020

The current implementation of helms3 does not support S3 bucket replicated content. Ideally we would be able to leverage helm's ability to fetch charts using relative URLs (helm/helm#3057)

It may in fact make sense to make all URLs relative, but for now my proposal is to make toggling this feature using a flag.

@bashims
Copy link
Contributor Author

bashims commented Sep 25, 2020

Here is the current help output from my proposed change:

 ./bin/helms3 reindex --help
usage: helm s3 reindex [<flags>] <repo>

Reindex the repository.

Flags:
  --help        Show context-sensitive help (also try --help-long and --help-man).
  --timeout=5m  Timeout for the whole operation to complete. Defaults to 5 minutes.

                If you don't use MFA, it may be reasonable to lower the timeout for the most commands, for example to 10 seconds.

                In opposite, in cases where you want to reindex big repository (e.g. 10 000 charts), you definitely want to increase the timeout.
  --acl=""      S3 Object ACL to set on the Chart and Index object.

                For more information on S3 ACLs please see https://docs.aws.amazon.com/AmazonS3/latest/dev/acl-overview.html#canned-acl
  --relative    Reindex with relative URL (useful when S3 buckets are replicated)

Args:
  <repo>  Target repository to reindex

@bashims
Copy link
Contributor Author

bashims commented Sep 29, 2020

Link to the PR: #122

@hypnoglow hypnoglow added this to the 0.10.0 milestone Oct 24, 2020
@hypnoglow
Copy link
Owner

The plugin version 0.10.0 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants