add support for adding relative URLs to the index (fixes #121) #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashims
force-pushed
the
support-relative-urls
branch
2 times, most recently
from
76cc91d
to
5a9a631
Compare
…kets) Signed-off-by: Benjamin Ash <bash@intelerad.com>
bashims
force-pushed
the
support-relative-urls
branch
from
5a9a631
to
23f4709
Compare
bashims
changed the title
|
@hypnoglow any chance you could look at this PR? Thanks! |
|
I think this is an elegant solution which obsoletes #56 |
|
@bashims this repo seems dead - how can one apply your PR and run with that version in helm? |
|
@davidkarlsen yeah not entirely sure what is going on here. You can install from my forked release if you want - I tagged it as v0.9.3 Installation instructions:
|
hypnoglow
requested changes
Oct 24, 2020
|
Tested it locally, works fine, thanks. |
|
@bashims I don't see any changes in the code. Have you pushed them? |
bashims
force-pushed
the
support-relative-urls
branch
2 times, most recently
from
5f6cdb5
to
e19eb20
Compare
Signed-off-by: Benjamin Ash <bash@intelerad.com>
bashims
force-pushed
the
support-relative-urls
branch
from
e19eb20
to
a041ddd
Compare
|
@hypnoglow just pushed |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Benjamin Ash bash@intelerad.com