Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to Helm v3 if Helm version is not detected #334

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

hypnoglow
Copy link
Owner

References: #329

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (5f4f891) 41.53% compared to head (dc16a29) 41.45%.

Files Patch % Lines
internal/helmutil/version.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #334      +/-   ##
==========================================
- Coverage   41.53%   41.45%   -0.09%     
==========================================
  Files          19       19              
  Lines         508      509       +1     
==========================================
  Hits          211      211              
- Misses        287      288       +1     
  Partials       10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hypnoglow hypnoglow merged commit cc971ef into master Nov 22, 2023
9 of 11 checks passed
@hypnoglow hypnoglow deleted the helm-detection-fallback-v3 branch November 22, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant