Use service URL from settings to construct welcome page URL #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the service URL from the extension's settings to construct the URL for the '/welcome' page and the URL pattern that allows requests made by the extension to set cookies for the Hypothesis domain. Previously both of these were hardcoded to 'https://hypothes.is', an issue that was noticed when testing deployment of the service to Skyliner under a different domain.
The first argument is an object mapping dependency names to values, not an array of arguments as the previous name suggested.
chdorner
approved these changes
Feb 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the service URL from the extension's settings to construct the URL
for the '/welcome' page and the URL pattern that allows requests made by
the extension to set cookies for the Hypothesis domain.
Previously both of these were hardcoded to 'https://hypothes.is', an
issue that was noticed when testing deployment of the service to
Skyliner under a different domain.
Manual testing:
settings/chrome-prod.jsonto a different domain (eg. 'https://next.hypothes.is/' - note the empty '/' path here is part of the service URL) and build the extension for production.<service domain>welcome