Implement very basic pluralization for tab count message

hypothesis · Jan 22, 2024 · 2f6b57b · 2f6b57b
1 parent 701d921
commit 2f6b57b
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 3 deletions.
diff --git a/src/sidebar/components/SelectionTabs.tsx b/src/sidebar/components/SelectionTabs.tsx
@@ -125,15 +125,23 @@ function SelectionTabs({
 
   const showNotesUnavailableMessage = selectedTab === 'note' && noteCount === 0;
 
+  // Naive simple English pluralization
+  const pluralize = (count: number, singular: string, plural: string) => {
+    return count === 1 ? singular : plural;
+  };
+
   const tabCountsSummaryPieces = [];
   if (annotationCount > 0) {
-    tabCountsSummaryPieces.push(`${annotationCount} annotations`);
+    const term = pluralize(annotationCount, 'annotation', 'annotations');
+    tabCountsSummaryPieces.push(`${annotationCount} ${term}`);
   }
   if (noteCount > 0) {
-    tabCountsSummaryPieces.push(`${noteCount} notes`);
+    const term = pluralize(noteCount, 'note', 'notes');
+    tabCountsSummaryPieces.push(`${noteCount} ${term}`);
   }
   if (orphanCount > 0) {
-    tabCountsSummaryPieces.push(`${orphanCount} orphans`);
+    const term = pluralize(noteCount, 'orphan', 'orphans');
+    tabCountsSummaryPieces.push(`${orphanCount} ${term}`);
   }
   const tabCountsSummary = tabCountsSummaryPieces.join(', ');
 

diff --git a/src/sidebar/components/test/SelectionTabs-test.js b/src/sidebar/components/test/SelectionTabs-test.js
@@ -340,6 +340,14 @@ describe('SelectionTabs', () => {
       },
       message: '2 annotations, 3 notes, 4 orphans',
     },
+    {
+      tabCounts: {
+        annotation: 1,
+        note: 1,
+        orphan: 1,
+      },
+      message: '1 annotation, 1 note, 1 orphan',
+    },
   ].forEach(({ tabCounts, message }) => {
     it('reports annotation count to screen readers', () => {
       const wrapper = createComponent({