Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the html_side_by_side feature flag #5664

Closed
robertknight opened this issue Jul 26, 2023 · 1 comment · Fixed by #6037
Closed

Remove the html_side_by_side feature flag #5664

robertknight opened this issue Jul 26, 2023 · 1 comment · Fixed by #6037

Comments

@robertknight
Copy link
Member

This feature has now been enabled for several weeks with no major issues. Removing the flag will simplify code, and also enable the behavior to activate earlier since the annotator side of the client will be able to apply changes without waiting for feature flags to be fetched from the backend.
@robertknight
Copy link
Member Author

Related to this, we have also been discussing making our feature flags tri-state (https://hypothes-is.slack.com/archives/C4K6M7P5E/p1690367647164099?thread_ts=1690303197.676149&cid=C4K6M7P5E). This allows us to enable a flag by changing its default behavior, while retaining the ability to override it if necessary (eg. for debugging).

@robertknight robertknight mentioned this issue Sep 7, 2023
Closed
robertknight added a commit that referenced this issue Dec 19, 2023
@robertknight
Remove html_side_by_side feature flag
ba556eb 
A boolean `HTMLIntegration._sideBySideEnabled` flag has been retained in case a
developer wants an easy way to turn this off for debugging.

Fixes #5664
robertknight added a commit that referenced this issue Dec 19, 2023
@robertknight
Remove html_side_by_side feature flag
5894069 
A boolean `HTMLIntegration._sideBySideEnabled` flag has been retained in case a
developer wants an easy way to turn this off for debugging.

Fixes #5664
@robertknight robertknight mentioned this issue Dec 19, 2023
Merged
robertknight added a commit that referenced this issue Jan 4, 2024
@robertknight
Remove html_side_by_side feature flag
4e316d5 
A boolean `HTMLIntegration._sideBySideEnabled` flag has been retained in case a
developer wants an easy way to turn this off for debugging.

Fixes #5664
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove html_side_by_side feature flag hypothesis/client
1 participant
@robertknight