Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can an embedded client’s share link omit hyp.is? #765

Closed
judell opened this issue Sep 4, 2018 · 1 comment
Closed

can an embedded client’s share link omit hyp.is? #765

judell opened this issue Sep 4, 2018 · 1 comment

Comments

@judell
Copy link
Contributor

judell commented Sep 4, 2018

For APA (and others, e.g. Atypon), via’s no-cookie policy is a showstopper. But when the client is embedded, there’s no need for via.

So what’s the problem? Share links.

An embedded client provides hyp.is links that resolve, unnecessarily and problematically, through via. Could an embedded client be configured to (and perhaps default to) plain (non-hyp.is) share links?

@dwhly
Copy link
Member

dwhly commented Sep 5, 2018

Could an embedded client be configured to (and perhaps default to) plain (non-hyp.is) share links?

I'm not sure what a "non-hyp.is" share link is. AFAIK we have no such thing. We did have via share links, but that's the problem here. There is an outstanding issue though that would address this: hypothesis/product-backlog#720 Which is essentially to be able to know a priori when the client is embedded on a target page before bouncer routes to via.

(Cards like this that are feature requests should be filed in product-backlog btw. Only client bugs should be filed in client repo.)

@judell judell closed this as completed Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants