Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct links not working properly with embedded clients #720

Open
dwhly opened this issue Jul 21, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@dwhly
Copy link
Member

commented Jul 21, 2018

Problem

Presently, bouncer is not able to detect that H is embedded on any given target page. It can only detect when the browser extension is present. Therefore, it cannot pass the direct link context (annotation, users, etc) to the embedded client.

This becomes particularly important when the client is embedded in particular ways, such as within subframes.

For instance, this annotation https://hyp.is/Crgo6IziEei8ikdTuMpbWg/osf.io/preprints/socarxiv/32n8y/
Links to an annotation on a COS preprint. The preprint PDF is embedded w/ H in a subframe on that page. But if you follow the direct link it will link instead to a random period at the bottom of the page.

This is a two level problem. It needs to work both when the user has the browser extension and when they don't (and typically we would route thru the proxy service).

Acceptance Criteria

Direct links (encoded w/ bouncer) need a way to be routed to embedded clients.

@dwhly dwhly changed the title Direct links should be aware that of embedded clients Direct links not properly working with embedded clients Jul 23, 2018

@dwhly dwhly changed the title Direct links not properly working with embedded clients Direct links not working properly with embedded clients Jul 23, 2018

@dwhly

This comment has been minimized.

Copy link
Member Author

commented Jul 23, 2018

Also, of course, what do we do when a user has annotated something on the page outside of the embedded content and wants to return there / share the location via a direct link. So some links will want to take the user back to the embedded content, some will want to take the user back to the surrounding non-embedded content. Perhaps this gets back to us storing whether the original annotation was made within a subframe or not-- brittle as that might be?

@ajpeddakotla

This comment has been minimized.

Copy link
Collaborator

commented Sep 5, 2018

Business Viability User Engagement Building Community Level of Effort
2 3 3 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.