Creating new annotations destroys existing unsaved ones

[seanh]

1. Create a new annotation, but don't save it and don't enter any text or tags.
2. Create another new annotation.

Expected: Annotation 1 should be deleted, I should see annotation 2 in the sidebar.

Actual: Annotation 1 is deleted but I do not see annotation 2 in the sidebar.

Second version of the same bug:

1. Create a new annotation, this time do enter some text and tags into it, but don't save it
2. Create another new annotation

Expected: I think the expected behaviour in this case is that I should see both annotations 1 and 2 in the sidebar?

Actual: annotation 1 is deleted, I see only annotation 2 in the sidebar.

The first issue bisects to this commit 1832a97 and I suspect the second issue is just another symptom of the same bug

[dwhly]

Expected: Annotation 1 should be deleted, I should see annotation 2 in the sidebar.

I'm trying to remember, is this what we designed? The argument being that I might have written something long form, gotten distracted, and then gone to create a new annotation forgetting that I hadn't saved the first.

Should we instead prevent the creation of a new one and perhaps scroll the existing one back into view?

But I'm struggling to find any of the threads of previous discussion around this, and may not be recalling correctly.

[robertknight]

@seanh 's descriptions of the actual and expected behavior are correct. This is broken because a couple of my recent changes did not correctly account for annotations without server assigned IDs. PR on its way.

[robertknight]

Also there was an existing but previously unnoticed bug where the orphan status of new annotations was not correctly initialized.

[dwhly]

🎉

[seanh]

Nice, @robertknight

[jeremydean]

I had thought we decided that two annotations can never be under construction at the same time?

[nickstenning]

No, you can have multiple in-progress drafts, but if your draft is empty (no text or tags) it will be discarded when you start a new annotation.