Fix quote anchoring in pages which add enumerable properties on Array.prototype #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otype Update dom-anchor-text-quote to incorporate tilgovi/dom-anchor-text-quote#11 which fixes quote anchoring on pages which include JS that adds enumerable properties to `Array.prototype`. Fixes hypothesis/product-backlog#143
Codecov Report@@ Coverage Diff @@
## master #226 +/- ##
==========================================
+ Coverage 75.17% 75.19% +0.01%
==========================================
Files 114 114
Lines 5705 5705
Branches 930 930
==========================================
+ Hits 4289 4290 +1
+ Misses 1416 1415 -1
Continue to review full report at Codecov.
|
|
Works here, verified that it fixes the problem on wapo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update dom-anchor-text-quote to incorporate
tilgovi/dom-anchor-text-quote#11 which fixes quote anchoring on pages
which include JS that adds enumerable properties to
Array.prototype.See hypothesis/product-backlog#143 (comment) for a detailed explanation of the problem and hypothesis/product-backlog#143 (comment) for URLs to test with using a production extension build.
Fixes hypothesis/product-backlog#143