Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix view switcher flash on iOS #482

Merged
merged 1 commit into from
Jul 4, 2017

Commits on Jul 3, 2017

  1. Fix view switcher flash on iOS

    The view switcher tabs at the top of the sidebar would flash grey for a
    moment after you clicked one. This removes the flash.
    
    This webkit "tap highlight" is actually an iOS Safari usability feature,
    it indicates to the user that their tap is being successfully recognized, and
    indicates which element they're tapping on. But I don't think it looks
    good with these tabs of ours, and it seems to interact badly with the
    background colour animated transition we're using (it seems to do the
    animated transition first and _then_ flash the tap highlight colour for
    a second).
    
    We're providing this indication by changing the colour of the tab
    anyway, so disable it.
    seanh committed Jul 3, 2017
    Configuration menu
    Copy the full SHA
    450beed View commit details
    Browse the repository at this point in the history