Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Bump puppeteer from 18.2.1 to 19.0.0" #4875

Merged

Conversation

lyzadanger
Copy link
Contributor

Reverts #4874

This update causes CI to fail in GH actions with:

[13:55:43] Starting Karma...

START:
17 10 [20](https://github.com/hypothesis/client/actions/runs/3265732944/jobs/5368414189#step:8:21)22 13:55:43.690:INFO [karma-server]: Karma v6.4.1 server started at http://localhost:9876/
17 10 2022 13:55:43.692:INFO [launcher]: Launching browsers ChromeHeadless_Custom with concurrency unlimited
17 10 2022 13:55:43.786:INFO [launcher]: Starting browser ChromeHeadless
17 10 2022 13:55:43.835:ERROR [launcher]: Cannot start ChromeHeadless
	Can not find the binary /home/runner/.cache/puppeteer/chrome/linux-1045629/chrome-linux/chrome
	Please set env variable CHROME_BIN
17 10 2022 13:55:43.835:ERROR [launcher]: ChromeHeadless stdout: 
17 10 2022 13:55:43.835:ERROR [launcher]: ChromeHeadless stderr: 

Finished in 0 secs / 0 secs @ 13:55:43 GMT+0000 (Coordinated Universal Time)

[13:55:43] '<anonymous>' errored after 30 s
[13:55:43] Error: Karma run failed with status 1
    at file:///home/runner/work/client/client/node_modules/@hypothesis/frontend-build/lib/tests.js:78:16
    at removeAllListeners (/home/runner/work/client/client/node_modules/karma/lib/server.js:468:9)
    at /home/runner/work/client/client/node_modules/karma/lib/server.js:475:9
    at Server.close (node:net:1767:9)
    at Object.onceWrapper (node:events:627:28)
    at Server.emit (node:events:525:35)
    at Server.emit (node:domain:552:15)
    at emitCloseNT (node:net:1820:8)
    at processTicksAndRejections (node:internal/process/task_queues:82:[21](https://github.com/hypothesis/client/actions/runs/3265732944/jobs/5368414189#step:8:22))
[13:55:43] 'test' errored after [30](https://github.com/hypothesis/client/actions/runs/3265732944/jobs/5368414189#step:8:31) s
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Error: Process completed with exit code 1.

A few notes:

  • Tests are running fine locally for me on Mac M1 (Chrome Headless launches fine) with this change (i.e. my local environment is not affected by this). This is still the case if I blow away node_modules first.
  • We are setting CHROME_BIN in karma.config.js: process.env.CHROME_BIN = require('puppeteer').executablePath();.
  • I am unclear on what makes our Chrome Headless "Custom" (browsers: ['ChromeHeadless_Custom'],) so it would be good to fill that knowledge gap.
  • There is change to cache paths in this puppeteer release: that may be relevant: feat!: use ~/.cache/puppeteer for browser downloads puppeteer/puppeteer#9095

@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Merging #4875 (9cc59b8) into main (1d1dc88) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #4875   +/-   ##
=======================================
  Coverage   99.17%   99.17%           
=======================================
  Files         230      230           
  Lines        8851     8851           
  Branches     2091     2091           
=======================================
  Hits         8778     8778           
  Misses         73       73           
Impacted Files Coverage Δ
src/annotator/components/NotebookModal.js 100.00% <ø> (ø)
src/sidebar/components/NotebookFilters.js 100.00% <ø> (ø)
src/sidebar/components/FilterSelect.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lyzadanger lyzadanger merged commit 252a168 into main Oct 17, 2022
@lyzadanger lyzadanger deleted the revert-4874-dependabot/npm_and_yarn/puppeteer-19.0.0 branch October 17, 2022 14:29
@robertknight
Copy link
Member

LGTM, we can look into this again at a more convenient time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants