Allow toggling focus filters independently #6070
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertknight
force-pushed
the
independent-focus-controls
branch
from
61c56f8
to
992f4bc
Compare
Instead of representing the state of multiple, logically independent filters as a single string with one button to toggle them, display a line of toggle buttons which each corresponds to a separate filter (user focus, page focus, selection). This has several advantages: - The user can toggle one focus filter without affecting others. For example in an assignment with a page range filter, a teacher can toggle a filter for the student they are currently grading without affecting the page range filter. - The UI better aligns with the internal data model, which avoids confusion - It is more space efficient and there are fewer words to read - It avoids the UI layout changing when filters are toggled on or off, because we just change the style but not the geometry of the toggle buttons depending on their pressed / not-pressed state.
robertknight
force-pushed
the
independent-focus-controls
branch
from
992f4bc
to
ca0f580
Compare
|
Something we'll have to address with the new design is making it more obvious why nothing is being shown if nothing matches all the active filters. In this PR a blank state looks like: 
We could fix this by adding some general empty-result state where the annotation list normally appears. |
11 tasks
|
Closed as the UI design has changed. See #6006 (comment) for current mocks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the focus filter controls to better support the existence of multiple focus filters.
On the main branch, all the active focus filters are combined into a single description, and there is one toggle button that activates / deactivates all of them. Here is a context where there is both a user filter and a page range filter active. This would represent for example a scenario where a teacher is grading a specific student in an ebook assignment where a page range is specified for the assignment:
The fact that we have two filters but one button leads to confusing labeling when we try to reflect the state when it is on/off. Here is the button after toggling "Show all":
On this branch, the two filters are represented as independent toggles (note the button presentation is not final, this PR is focused on the logical UI change):
With the page range filter deactivated:
Combined with a filter query:
The revised UI has several advantages over the previous approach:
There are some further changes planned but not implemented in this PR: