Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine most recent highlighted annotation by its updated date #6341

Merged
merged 1 commit into from Apr 17, 2024

Conversation

acelaya
Copy link
Contributor

@acelaya acelaya commented Apr 16, 2024

Following up on #6338, do an actual check of highlighted annotations dates to determine which one is the most recent one, instead of implicitly trusting their order in the store.

This logic is more robust and future-proof, in case the logic to add them to the store eventually changes.

Testing

You can follow the same steps described in #6338

@acelaya acelaya marked this pull request as ready for review April 16, 2024 12:16
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.43%. Comparing base (239a63b) to head (75a1a05).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6341   +/-   ##
=======================================
  Coverage   99.43%   99.43%           
=======================================
  Files         271      271           
  Lines       10224    10231    +7     
  Branches     2420     2424    +4     
=======================================
+ Hits        10166    10173    +7     
  Misses         58       58           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@robertknight robertknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/sidebar/components/ThreadList.tsx Show resolved Hide resolved
@acelaya acelaya merged commit 8230c26 into main Apr 17, 2024
4 checks passed
@acelaya acelaya deleted the last-highlight-check-date branch April 17, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants