Fix the cookiecutter's tests #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops: the DB option is called `postgres` not `db`, and there's no `services` option.
jon-betts
approved these changes
Jul 10, 2023
There was a problem hiding this comment.
This works, but it worked in main too, but I suppose it wasn't testing what we thought it was. It seems we ignore invalid / unexpected arguments, so this was setting up the templated test environments incorrectly.
This also includes some extra fixes discovered while debugging some local issues on my machine.
I think you can use a |
This also stops if make requirements fails, where we would previously continue on, which makes debugging a bit harder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oops: the DB option is called
postgresnotdb, and there's noservicesoption.