Fix typecheck after making it mandatory in CI and make sure (#77)

* Fix typecheck after making it mandatory in CI and make sure

* Reformat code after black upgrade

* Linting fixes after pylint upgrade

.cookiecutter/includes/mypy/disables

@@ -0,0 +1,3 @@
+"no-redef",
+"assignment",
+"import-not-found",

.cookiecutter/includes/pylint/disables

@@ -0,0 +1,3 @@
+# Lots of false positives
+"no-value-for-parameter",
+

.cookiecutter/includes/tests/pylint/disables

@@ -0,0 +1,3 @@
+# Lots of false positives
+"no-value-for-parameter",
+

pyproject.toml

@@ -128,6 +128,10 @@ disable = [
 
     # Issues to disable this for false positives, disabling it globally in the meantime https://github.com/PyCQA/pylint/issues/214
     "duplicate-code",
+
+    # Lots of false positives
+    "no-value-for-parameter",
+
 ]
 
 good-names = [
@@ -147,6 +151,9 @@ warn_unused_ignores = true
 disable_error_code = [
     # https://mypy.readthedocs.io/en/stable/error_code_list.html#code-import-untyped
     "import-untyped",
+    "no-redef",
+    "assignment",
+    "import-not-found",
 ]
 
 [[tool.mypy.overrides]]

src/h_matchers/interface.py

@@ -1,4 +1,5 @@
 """The public interface class for comparing with things."""
+
 from h_matchers.matcher import collection
 from h_matchers.matcher import number as _number
 from h_matchers.matcher.anything import AnyThing

src/h_matchers/matcher/anything.py

@@ -1,4 +1,5 @@
 """A matcher that matches anything."""
+
 from h_matchers.matcher.core import Matcher
 
 

src/h_matchers/matcher/collection/__init__.py

@@ -1,4 +1,5 @@
 """Flexible matchers for various collection types in a fluent style."""
+
 from types import GeneratorType
 
 from h_matchers.exception import NoMatch

src/h_matchers/matcher/collection/_mixin/contains.py

@@ -1,4 +1,5 @@
 """A mixin for AnyCollection which lets you check for specific items."""
+
 from types import GeneratorType
 
 from h_matchers.decorator import fluent_entrypoint

src/h_matchers/matcher/combination.py

@@ -1,4 +1,5 @@
 """Matchers formed of combinations of other things."""
+
 from h_matchers.matcher.core import Matcher
 
 

src/h_matchers/matcher/object.py

@@ -1,4 +1,5 @@
 """Matchers for simple objects."""
+
 from h_matchers.decorator import fluent_entrypoint
 from h_matchers.matcher.core import Matcher
 

src/h_matchers/matcher/web/request.py

@@ -1,4 +1,5 @@
 """A matcher that matches various request objects in HTTP type libraries."""
+
 from copy import deepcopy
 
 from h_matchers.decorator import fluent_entrypoint

src/h_matchers/matcher/web/url/core.py

@@ -57,6 +57,7 @@
     Any.url(path="/foo") == "foo"                          # True
     Any.url(path="foo") == "/foo"                          # True
 """
+
 import re
 from collections import Counter
 from urllib.parse import parse_qsl, urlparse

src/h_matchers/matcher/web/url/fluent.py

@@ -1,4 +1,5 @@
 """A fluent interface over AnyURLCore for matching URLs."""
+
 from h_matchers.decorator import fluent_entrypoint
 from h_matchers.matcher.collection import AnyMapping
 from h_matchers.matcher.strings import AnyString

tests/pyproject.toml

@@ -68,6 +68,10 @@ disable = [
 
     # Issues to disable this for false positives, disabling it globally in the meantime https://github.com/PyCQA/pylint/issues/214
     "duplicate-code",
+
+    # Lots of false positives
+    "no-value-for-parameter",
+
 ]
 
 # Just disable PyLint's name style checking for the tests, because we

tests/unit/data_types.py

@@ -1,4 +1,5 @@
 """Data types for testing the matchers."""
+
 import enum
 from decimal import Decimal
 

tests/unit/h_matchers/matcher/collection/_mixin/size_test.py

@@ -41,6 +41,7 @@ def test_it_complains_with_incorrect_size(self):
     def test_it_matches_maximum_size(self):
         matcher = HostClass.of_size(at_most=2)
 
+        # pylint:disable=use-implicit-booleaness-not-comparison
         assert matcher == []
         assert matcher == [1, 2]
         assert matcher != [1, 2, 3]

tests/unit/h_matchers/matcher/collection/_mixin/type_test.py

@@ -17,6 +17,7 @@ class TestTypeMixin:
     def test_it_matches_specific_class(self):
         matcher = HostClass.of_type(list)
 
+        # pylint:disable=use-implicit-booleaness-not-comparison
         assert matcher == []
         assert [] == matcher
         assert matcher != set()