Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email notification on reply #1004

Closed
3 of 7 tasks
dwhly opened this issue Dec 17, 2013 · 10 comments
Closed
3 of 7 tasks

Email notification on reply #1004

dwhly opened this issue Dec 17, 2013 · 10 comments
Assignees
Milestone

Comments

@dwhly
Copy link
Member

dwhly commented Dec 17, 2013

Steps for implementation

This will be important as part of the overall W3C work here:
http://docs.webplatform.org/wiki/WPD:Annotations

@csillag
Copy link
Contributor

csillag commented Dec 17, 2013

I think #581 is the closest one, but in only covers the email notifications part, and does not specifically mention replies. (I will add that right now.)

The ability to parse emails, and turn them into annotations is new, so this is not a duplicate.

@csillag
Copy link
Contributor

csillag commented Jan 2, 2014

I have updated the OP with pointers to individual issues describing the wanted features, and changed title to focus on the remaining new feature

@gergely-ujvari
Copy link
Contributor

Currently it is hard to test this in a dokku instance, but here is what should be done for testing it.

  • Since every dokku update purges the user db, you've to register a new user to be able to reply
  • You've to reregister the user whose reply you're willing to reply.
  • After this you'll get the e-mail notification.

In normal working the user db is in sync with the annotation db, so this is a dokku case only. I've fixed the bug that it simply returns if the user is not found. (We should do this for redacted annotations)

@gergely-ujvari
Copy link
Contributor

New test server: https://email2.dokku.hypothes.is/
It is doing what email1 does, but it uses user subscriptions according to v2 specification. (I'll add the ui endpoint for streampage soon)

@gergely-ujvari
Copy link
Contributor

Sending e-mails to document owners feature may be delayed by this issue: #1046
(I'm investigating)

@tilgovi
Copy link
Contributor

tilgovi commented Jun 30, 2014

Closing in favor of hypothesis/vision#44

@tilgovi tilgovi closed this as completed Jun 30, 2014
@dwhly dwhly reopened this Jul 7, 2014
@dwhly dwhly added this to the 2014-08-08 milestone Jul 7, 2014
@dwhly dwhly changed the title Annotations from email replies Email notification on reply Jul 7, 2014
@BigBlueHat
Copy link
Contributor

@dwhly I'm guessing from this re-open that hypothesis/vision#44 is insufficient?

If this issue is due in the currently connected milestone (2014-08-08), do you want all the mentioned issues completed? If so, we need to associate those to 2014-08-08 so it's scoped properly.

Thanks!

@tilgovi
Copy link
Contributor

tilgovi commented Jul 24, 2014

This issue is not sufficiently well described here and the implementation steps are not at all in the direction I'd like to take this.

I would like to move this outside the h repo, which is why I opened hypothesis/vision#44 and even left a message there stating it obsoletes this.

I'm guessing that @dwhly just wanted this on the roadmap. As such, I've added the Roadmap: Major label to the vision issue and I'm closing this again.

@tilgovi tilgovi closed this as completed Jul 24, 2014
@dwhly
Copy link
Member Author

dwhly commented Jul 25, 2014

I think this got reopened during our roadmap back and forth discussion about where things belonged. It was also scheduled on the current milestone. updating hypothesis/vision#44 accordingly (assuming it's ok when only portions of things are addressed in milestones?)

@BigBlueHat
Copy link
Contributor

@dwhly only if those "portions of things" are shippable in themselves, or the shippable issues are also scheduled for the milestone. Vision issues are representative of a "large effort" so they shouldn't ever be expected to close during a milestone--without lots of related, implementable issues closing "under" them.

We'll likely need to start making implementable issues more often--vs. just these big guys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants