Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PeerJ's Paper Now problems... #2324

Closed
BigBlueHat opened this issue Jun 16, 2015 · 9 comments
Closed

PeerJ's Paper Now problems... #2324

BigBlueHat opened this issue Jun 16, 2015 · 9 comments

Comments

@BigBlueHat
Copy link
Contributor

There's a link to Via includes in the Paper Now UI. Generally, it works great...but there are some exceptions.

Testing their example page on it's own, via Via, and with the Chrome extension.

Firefox + Via:

  • selecting is erratic...selection jumps about strangely
    • generally it narrows in on a single paragraph...and highlights the whole thing
    • double clicking the word to select usually causes the selection to disappear/stop
    • there are some click-handlers in the theme that enlarge the math on click
  • selection works fine on the test page with Hypothes.is off
  • several JS errors referencing either their included JS or our provided angular.js--likely the source of the selection problems
  • sidebar only shows a single annotation by invisiblecomma

Firefox + bookmarklet:

  • sidebar tabs (currently) count 9 annotations
    • 1 is the same one by invisiblecomma...but this time it has a tag (earlier it did not)
    • 2 others are visible in the sidebar (by jeremydean and memartone), but are not visible in the page
    • the other 6 are mysteriously not displaying in the sidebar

Chrome + Via:

Chrome + Extension:

  • 2 annotations noted in the tabs (not 9...)
    • one by jeremydean and the other by memartone
    • the invisiblecomma one is absent...
  • lots of JS errors...different ones this time...mostly reference "Uncaught Error: Found no info for path..."
  • double-clicking (to select) throws the selection from the word you're on down to the bottom of the page...true on both sides of the page

In all of these cases the "note | highlight" adder icon only showed sporadically--with Chrome + Via the most frequently successful (which was like...1 in 20...).

Likely, the JS related conflicts are to blame for most of these. However, I thought documenting them might help narrow the target...I hope. 😕

@tilgovi
Copy link
Contributor

tilgovi commented Jul 21, 2015

Needs to be re-evaluated now that the anchoring rewrite has shipped.

@judell
Copy link
Contributor

judell commented Jul 21, 2015

Notes on what I continue to see at https://peerj.github.io/paper-now/:

  • In FF, clicking highlights (e.g. 37°C) doesn't pop the sidebar and focus the annotation
  • selection pops the adder but clicking New Note does not pop; the sidebar and focus a new annotation
  • these console complaints:

image

@tilgovi
Copy link
Contributor

tilgovi commented Jul 21, 2015

I always saw console complaints about Polymer not being a function, at least on via.

@tilgovi
Copy link
Contributor

tilgovi commented Jul 21, 2015

It would be nice to try to narrow these down a bit, like by trying to repro some of this on polymer demos.

@tilgovi
Copy link
Contributor

tilgovi commented Jul 21, 2015

The a.getAttribute traceback happens even without the annotator loaded, so that's not us.

@tilgovi
Copy link
Contributor

tilgovi commented Jul 21, 2015

I think the reduce of empty array bit is something I have seen before and it's the reduce in the highlight module's getBoundingClientRect function.

@tilgovi
Copy link
Contributor

tilgovi commented Jul 21, 2015

That happens whenever we find a range but don't create any highlights for it during anchoring. This can happen when the highlighted portion is only whitespace, or perhaps when we find a quote by prefix but only the prefix is there, not the quote.

@tilgovi
Copy link
Contributor

tilgovi commented Jul 21, 2015

So, that's some info for anyone who investigates. No one should feel compelled to follow up on that right now, but first thing to do here is to break apart the separate issues and put them under something other than "PeerJ's Paper Now problems..."

@judell
Copy link
Contributor

judell commented Nov 19, 2015

Closed in favor of #2730.

@judell judell closed this as completed Nov 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants