New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PeerJ's Paper Now problems... #2324
Comments
Needs to be re-evaluated now that the anchoring rewrite has shipped. |
Notes on what I continue to see at https://peerj.github.io/paper-now/:
|
I always saw console complaints about |
It would be nice to try to narrow these down a bit, like by trying to repro some of this on polymer demos. |
The |
I think the reduce of empty array bit is something I have seen before and it's the reduce in the highlight module's getBoundingClientRect function. |
That happens whenever we find a range but don't create any highlights for it during anchoring. This can happen when the highlighted portion is only whitespace, or perhaps when we find a quote by prefix but only the prefix is there, not the quote. |
So, that's some info for anyone who investigates. No one should feel compelled to follow up on that right now, but first thing to do here is to break apart the separate issues and put them under something other than "PeerJ's Paper Now problems..." |
Closed in favor of #2730. |
There's a link to Via includes in the Paper Now UI. Generally, it works great...but there are some exceptions.
Testing their example page on it's own, via Via, and with the Chrome extension.
Firefox + Via:
invisiblecomma
Firefox + bookmarklet:
invisiblecomma
...but this time it has a tag (earlier it did not)jeremydean
andmemartone
), but are not visible in the pageChrome + Via:
invisiblecomma
(sans tag), and...one fromseanh
(previously unseen in other scenarios...)seanh
annotation is borked: https://hypothes.is/api/annotations/HqRbqZ5nQ4WbldCicsLlcA[object Object]
as the value forsource
insidetarget
, foruri
, and for the linkhref
valuesinvisiblecomma
one... https://hypothes.is/api/annotations/QJEVZJWIQr6JpVVEpr0slAChrome + Extension:
jeremydean
and the other bymemartone
invisiblecomma
one is absent...In all of these cases the "note | highlight" adder icon only showed sporadically--with Chrome + Via the most frequently successful (which was like...1 in 20...).
Likely, the JS related conflicts are to blame for most of these. However, I thought documenting them might help narrow the target...I hope. 😕
The text was updated successfully, but these errors were encountered: