Simplify handling of admin permissions #2430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need a custom context resource factory for admin-only views, we just need to give the 'group:admin' principal the 'admin' permission on the root resources, and add the 'admin' permission to admin views.
|
LGTM. I think 'admin' as a permission name is fine for these views, as the permission really kind of is "behave as a site admin" quite explicitly, but we should be cautious about missing the main point of a capability-based access control system: namely decoupling names for authorisation groups from names of capabilities. (So, don't fall into the trap of thinking that everything an admin should be able to do is to be guarded by the "admin" permission...) |
nickstenning
added a commit
that referenced
this pull request
Aug 3, 2015
…ndling Simplify handling of admin permissions
|
I was worried that maybe we used 'admin' as a permission name on some of our annotations too |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tilgovi I realised that #2424 was kind of silly. We don't need a custom context resource factory for admin-only views, we just need to give the 'group:admin' principal the 'admin' permission on the root resources, and add the 'admin' permission to admin views.
That is, assuming we don't already use a permission called 'admin' anywhere else.