long urls don't break in activity page cards

[judell]

We're doing this:

But it looks like we also (or instead?) need to do this:

[judell]

/cc @dawariley

[judell]

The PubMedCommons import turned up a bunch of these, e.g.:

[segdeha]

URLs in practice can be upwards of 2000 characters, so another solution, rather than just wrapping the URL, would be to do as many services these days do and display a subset of the characters of the URL while preserving the full URL in the title attribute of the anchor tag.

<a href="[full URL]" title="[full URL]">[no protocol, full domain name, X number of characters of the path, ellipsis if the path has been truncated]</a>

So, a long URL might be rendered like the following:

<a href="https://github.com/hypothesis/h/issues/4727#issuecomment-364552455" title="https://github.com/hypothesis/h/issues/4727#issuecomment-364552455">github.com/hypothesis/h/…</a>

[dwhly]

another solution, rather than just wrapping the URL, would be to do as many services these days do and display a subset of the characters of the URL while preserving the full URL in the title attribute of the anchor tag

I like this (with enough characters that normal info about the domain and page is shown so that a human can say "oh, yeah, that page". 30-40?)

But another Q of course is: What do we do in the sidebar? I think we should tend towards harmonizing the two.

[dawachan]

Thanks for bringing this to our attention @judell. The solution I would also propose would be to truncate the url, not simply wrapping. Text wrapping is an improvement to it overspilling the 'div' layer which it currently does. I think the more reliable and robust solution for long urls is to truncate the url for the reasons @segdeha has outlined above.

[dawachan]

No further UX/design input is needed and if everyone is ok with the truncating solution it is good to go from my point of view, I will move it out of the design queue into one of the other columns as it is now up to @ajpeddakotla and the delivery team to pick this up when there is time. Thanks for including me!

[dwhly]

Per discussion in our product meeting today w/ @dawariley and @ajpeddakotla, lets make sure we harmonize solution we're using in sidebar and activity pages.

[robertknight]

It looks to me like this was fixed by #4943