Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unreleased extension: selecting annotations by clicking on highlights is broken #698

Closed
csillag opened this issue Aug 28, 2013 · 4 comments

Comments

@csillag
Copy link
Contributor

csillag commented Aug 28, 2013

I have just deployed a new version on prod. Works great from bookmarklet.
However, during the final local test before releasing the new build of the extension, I have noticed that selecting annotations by clicking on the highlight in always-on mode does not work.

I have checked again the bookmarklet (using the code that is now on prod), and in that version, it works OK. Looks like this is an extension-only problem.

The problem is that we are now in a half-deployed state: prod has been updated, but extension has not. I know that there are incompatibilities, so the old code won't work with the new one.

So I will now revert prod to the previous version, so that it is compatible with the released extension.

@csillag
Copy link
Contributor Author

csillag commented Aug 28, 2013

Prod is back at 2f6dd1e

@csillag
Copy link
Contributor Author

csillag commented Aug 28, 2013

If #699 was done, it would not be necessary to revert prod in cases like this.

@csillag
Copy link
Contributor Author

csillag commented Aug 28, 2013

I have to change location now. I will probably leave prod as it is right now. (It's working the save way was as it was 2 hours ago, just does not have the latest 3 bug-fixes.)

@csillag
Copy link
Contributor Author

csillag commented Aug 29, 2013

After fixing #702, re-deploying prod, and rebuilding the extension, the problem just went away. Closing this.

@csillag csillag closed this as completed Aug 29, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant