Skip to content

Commit

Permalink
SpeedGrader in VS launches
Browse files Browse the repository at this point in the history
  • Loading branch information
marcospri committed Nov 15, 2021
1 parent a0b7980 commit 0d95d5b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -216,8 +216,8 @@ export default function BasicLTILaunchApp() {
return;
}

// Don't report a submission until the URL has been successfully fetched.
if (!contentUrl) {
// Don't report a submission until we have the data needed to display the assignment content
if (!contentUrl && !vitalSourceConfig) {
return;
}
try {
Expand All @@ -233,7 +233,7 @@ export default function BasicLTILaunchApp() {
// submission.
handleError(e, 'error-reporting-submission', false);
}
}, [authToken, canvas.speedGrader, contentUrl]);
}, [authToken, canvas.speedGrader, contentUrl, vitalSourceConfig]);

useEffect(() => {
reportSubmission();
Expand Down
1 change: 1 addition & 0 deletions lms/validation/_lti_launch_params.py
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ def _decode_url(self, _data, **_kwargs): # pylint:disable=no-self-use
url.lower().startswith("http%3a")
or url.lower().startswith("https%3a")
or url.lower().startswith("canvas%3a")
or url.lower().startswith("vitalsource%3a")
):
url = unquote(url)
_data["url"] = url
Expand Down

0 comments on commit 0d95d5b

Please sign in to comment.