Re-enable canvas_db_configured_basic_lti_launch view #3320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until canvas assignment are stored on the DB on creation/editing this view will only handle launches of already present in the DB canvas file assignments (regular and SpeedGrader launches).
marcospri
changed the title
seanh
approved these changes
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until canvas assignments are stored on the DB on creation/editing this view will only handle launches of already present in the DB canvas file assignments (regular and SpeedGrader launches).
The view was disabled after the problems with legacy SpeedGrader launches. This enables it again with a
legacy_speedgrader=Falseto guard against those problems.In summary, before #3126 is merged, in this PR:
All url configured assignments (ie all no canvas-files assignments) use the
url_configured_basic_lti_launchview. That includes legacy speedgrader url assignments which where not covered by the functional tests yet.Newly created canvas file assignment will be handled
legacy_canvas_file_basic_lti_launch(which will create a new row in the DB)Subsequent launches of those canvas file assignments will be handled by
canvas_db_configured_basic_lti_launchExcept, when launched as legacy speedgrader, where they will still be handled by
legacy_canvas_file_basic_lti_launch