Store VS assignments on the DB #3341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcospri
force-pushed
the
ext_lti_assignment_id-column-frontend
branch
3 times, most recently
from
c68e341
to
cdb1992
Compare
marcospri
force-pushed
the
vs-assignments-db
branch
2 times, most recently
from
422fae8
to
513d42c
Compare
marcospri
force-pushed
the
vs-assignments-db
branch
from
513d42c
to
88c0c5d
Compare
marcospri
commented
Nov 9, 2021
| @@ -235,7 +235,7 @@ export default function BasicLTILaunchApp() { | |||
| } | |||
|
|
|||
| // Don't report a submission until the URL has been successfully fetched. | |||
There was a problem hiding this comment.
Not sure how to rephrase this comment "... until the content has been configured"?
There was a problem hiding this comment.
I suggest something like "Don't report a submission until we have the data needed to display the assignment content".
marcospri
commented
Nov 9, 2021
| self.store_lti_data() | ||
| self.context.js_config.maybe_enable_grading() | ||
| self.context.js_config.add_vitalsource_launch_config( | ||
| self.request.params["book_id"], self.request.params.get("cfi") |
There was a problem hiding this comment.
We don't need to send any params to SpeedGrader as we can read the information from the DB assignment.
| @@ -186,13 +186,6 @@ def __call__(self, context, request): | |||
| return ("canvas_file" in request.params) == self.value | |||
|
|
|||
|
|
|||
| class VitalSourceBook(Base): | |||
There was a problem hiding this comment.
VitalSource assignments become regular DB-Configured ones.
seanh
approved these changes
Nov 9, 2021
marcospri
force-pushed
the
vs-assignments-db
branch
from
88c0c5d
to
d6a3407
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #3329
Handles VitalSource assignments like any other type of assignment on Canvas.
Testing as #3126 but using VS assignments as well.