Make make services wait for healthchecks to pass using --wait
#5556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables starting lms services and the dev server by running `make services && make dev`, without encountering errors due to the DB not being ready. nb. The `--wait` flag is missing from the docs but see docker/compose#8777.
robertknight
added a commit
to hypothesis/h
that referenced
this pull request
Jul 10, 2023
Switch to Docker Compose v2 and change `make services` to use the `--wait` flag to wait for healthchecks to pass before exiting. Also add a healthcheck for Elasticsearch. The Makefile changes follow the pattern in the lms app. Together these changes mean that h and its services can be started with `make services && make dev`, without encountering errors due to Postgres / Elasticsearch not being ready to connect. The `start_period` setting is set to a generous value (1 min) as normal startup times for ES are quite long (15-20s on my 2020 Intel MacBook Pro). See also hypothesis/lms#5556.
|
Oh nice, I wasn't aware of FYI you can just run |
seanh
approved these changes
Jul 10, 2023
seanh
requested changes
Jul 10, 2023
There was a problem hiding this comment.
Oh, apologies, for some reason I thought this was in h (which doesn't use the cookiecutter yet): In LMS a Makefile change like this would have to be made in the cookiecutter (specifically here: https://github.com/hypothesis/cookiecutters/blob/1a447d9aa982a7dee029777f343811746d76aa8d/_shared/project/Makefile#L10) and then it'll get applied to all cookiecutter-using projects
|
OK, I moved this change to the cookiecutter here: hypothesis/cookiecutters#141. |
robertknight
added a commit
to hypothesis/h
that referenced
this pull request
Jul 10, 2023
Switch to Docker Compose v2 and change `make services` to use the `--wait` flag to wait for healthchecks to pass before exiting. Also add a healthcheck for Elasticsearch. The Makefile changes follow the pattern in the lms app. Together these changes mean that h and its services can be started with `make services && make dev`, without encountering errors due to Postgres / Elasticsearch not being ready to connect. The `start_period` setting is set to a generous value (1 min) as normal startup times for ES are quite long (15-20s on my 2020 Intel MacBook Pro). See also hypothesis/lms#5556.
robertknight
added a commit
to hypothesis/h
that referenced
this pull request
Jul 10, 2023
Switch to Docker Compose v2 and change `make services` to use the `--wait` flag to wait for healthchecks to pass before exiting. Also add a healthcheck for Elasticsearch. The Makefile changes follow the pattern in the lms app. Together these changes mean that h and its services can be started with `make services && make dev`, without encountering errors due to Postgres / Elasticsearch not being ready to connect. The `start_period` setting is set to a generous value (1 min) as normal startup times for ES are quite long (15-20s on my 2020 Intel MacBook Pro). See also hypothesis/lms#5556.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables starting lms services and the dev server by running
make services && make dev, without encountering errors due to the DB not being ready.nb. The
--waitflag is missing from the docs but see docker/compose#8777.