Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove feature flag checks for vitalsource.page_ranges flag #6111

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

robertknight
Copy link
Member

@robertknight robertknight commented Mar 11, 2024

This enables VitalSource page range selection for all installs. The consequences of this are:

  • When configuring a VitalSource assignment, there is the option to "Choose a chapter or page range" instead of "Pick a place to start reading"
  • In the assignment, we show only annotations from the selected chapter or page range, and show a toggle button in the client to choose whether to show annotations from the rest of the book
  • When users navigate outside the selected chapter / page range, they are shown a notification that any annotations they create there may not count towards the assignment, but they are still able to annotate.
  • Existing VitalSource assignments are unaffected, and work the same as before

This enables VitalSource page ranges for all installs.
@robertknight robertknight marked this pull request as ready for review March 11, 2024 16:17
@robertknight
Copy link
Member Author

I'm going to hold off merging this until others have had a chance to test a fix for a problem reported in https://hypothes-is.slack.com/archives/C4K6M7P5E/p1710190672323349.

@robertknight
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants