Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply updates from cookiecutter and add Python 3.7 support #10

Merged
merged 2 commits into from
Aug 31, 2022
Merged

Apply updates from cookiecutter and add Python 3.7 support #10

merged 2 commits into from
Aug 31, 2022

Conversation

seanh
Copy link
Contributor

@seanh seanh commented Aug 31, 2022 •
edited
Loading

No description provided.

@seanh seanh requested a review from marcospri August 31, 2022 12:11
seanh
seanh commented Aug 31, 2022
View reviewed changes
src/tox_recreate/plugin.py
@@ -7,13 +7,13 @@
hookimpl = pluggy.HookimplMarker("tox")


@lru_cache
@lru_cache(maxsize=None)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't use @lru_cache without an argument in 3.7

marcospri
marcospri approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@marcospri marcospri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As expected the test fail due the the python version dependency:

ERROR: Ignored the following versions that require a different python version: 0.0.1 Requires-Python >=3.8; 0.0.2 Requires-Python >=3.8; 0.0.3 Requires-Python >=3.8; 0.0.4 Requires-Python >=3.8

@seanh seanh merged commit 795c0a8 into main Aug 31, 2022
@seanh seanh deleted the update-cookiecutter-and-add-37 branch August 31, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcospri marcospri marcospri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@seanh @marcospri