Make the application be the WSGI app instead of create one #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jon-betts
force-pushed
the
be-the-app
branch
from
d396254
to
c40402c
Compare
seanh
approved these changes
Sep 8, 2020
jon-betts
force-pushed
the
test-coverage
branch
from
310a235
to
1a83cc0
Compare
For whatever mysterious reason, this caused the gevent monkey patching to kick in at a different time when importing the FrontEndApp, which makes me think we don't need it...
jon-betts
force-pushed
the
be-the-app
branch
from
c40402c
to
ed7a823
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For whatever mysterious reason, this caused the gevent monkey patching
to kick in at a different time when importing the FrontEndApp, which
makes me think we don't need it...
Why?
This is to set us up for the header blocking PR: #4. We're going to need to modify the headers on the way in and out. This means we need to be the app, rather than just have one.