Update to Python 3.11 #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the current version of pywb, viahtml can be run on macOS (tested under macOS 14.4) without this workaround.
marcospri
reviewed
May 2, 2024
| @@ -1 +1 @@ | |||
| 3.8.12 | |||
| 3.11.7 | |||
There was a problem hiding this comment.
Not that important but this is a minor version lower than the version in Dockerfile
There was a problem hiding this comment.
I copied this from h. Dependabot updates the Dockerfile but it doesn't know about .python-version, so we'll have this minor skew across our projects.
There was a problem hiding this comment.
I don't think we've ever seen problems due to Python minor version differences between what we use in dev and what the Docker container uses, but perhaps this could be bumped periodically by the cookiecutter or something? CC @seanh .
|
For: #505 |
marcospri
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#657 added support for Python 3.11 in pywb, so hopefully we can now update the project as a whole.
I also removed a workaround for macOS that appears to be obsolete with the latest Python and pywb versions.
In case it happens to anyone else: After updating to Python 3.11,
make functestsinitially failed on my system with aSystemError: unknown opcodeerror. Removing my checkout ofviahtmland running the tests in a fresh clone of the repo solved the issue.