-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New hypre release 2.18.1 #55
Comments
|
It looks like the copyright block in src/HYPREf.h tries to use 'c' at the beginning of the line instead of '!' and this causes a compile error. This is for 2.18.0 |
Using 'c' goes way back. Is this really now considered a bug in Fortran 90/95/...? If so, there are a number of other instances in hypre that we will have to fix, not just the headers. I just did some quick research on this, and it looks like Fortran 77 actually changed the comment character to '*' but accepted 'c' for backward compatibility. Fortran 90 changed it to '!' and I'm not sure what happened to backward compatibility. I guess we fixed this in 'HYPREf.h' a long time ago (and I just don't remember), because we clearly had the '!' character there before the license change. I'll fix. |
Thanks! Intel ifort, 18.0.2 gave this error. |
@bobby-philip Let me know if my last commit fixes the problem. Thanks! |
Hi @balay , Would you mind running the current master branch through your testing and let us know if all is good before we tag this for release? Let me know. Thanks! -Rob |
@rfalgout will check and update |
I ran a full petsc test pipeline on this snapshot of hypre, and a few xsdk workstation builds [i.e no runs] on linux,osx (gcc,clang,intel) - they all are fine. |
Thanks, Satish! |
Hello @hypre-space/developers . If there are no complaints, I will tag the release later this morning. |
I checked out the dev version and it built fine against Intel. Thanks!
…On Mon, Oct 14, 2019 at 5:09 PM Rob Falgout ***@***.***> wrote:
@bobby-philip <https://github.com/bobby-philip> Let me know if my last
commit fixes the problem. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#55?email_source=notifications&email_token=AB4BZJLG2MSPERU6ASLXNJ3QOT33TA5CNFSM4JAT6K6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBG4RWA#issuecomment-541968600>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB4BZJMYCLQHAWEN2OEWEPDQOT33TANCNFSM4JAT6K6A>
.
|
Thanks, Bobby! |
The release is done. Thanks! |
Hello @hypre-space/developers,
We are in the process of doing a new hypre patch release, so please hold off on making changes to the master branch until it is done. We still plan on doing a minor release soon with the new features that didn't make it into 2.18.
Thanks!
-Rob
The text was updated successfully, but these errors were encountered: