Add hypre_MGRSetGlobalSmootherAtLevel to MGR
#1091
Conversation
There was a problem hiding this comment.
@victorapm this looks good to me, if it has been tested to work. It will be good to have a regression test to cover this case and make sure things are being destroyed correctly. I am fine with it if that is done in a separate PR. Thanks!!
src/parcsr_ls/HYPRE_parcsr_ls.h
Outdated
| * @note Unlike some other setup functions that might require an array to set options across multiple | ||
| * levels, this function focuses on a single level, identified by the \e level parameter. | ||
| * | ||
| * @warning If `hypre_MGRSetLevelSmoothType` has previously been called, setting a global smoother at |
There was a problem hiding this comment.
Maybe we should rephrase this statement to say that this call takes precedence for setting the smoother at that level or overrides all other options for the smoother at that level (irrespective of when they are called).
There was a problem hiding this comment.
Sounds good! Do you want to make the change?
There was a problem hiding this comment.
@victorapm, I made a few comments for your review. Otherwise, the overall idea looks good to me. Thanks.
Add
hypre_MGRSetGlobalSmootherAtLevelwhich allows users to set "external" hypre solvers as a global relaxation method in MGR