Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dispatch_str for MoveFocusedWindowToWorkspace(Silent) #159

Merged
merged 4 commits into from
Jan 27, 2024
Merged

Fix dispatch_str for MoveFocusedWindowToWorkspace(Silent) #159

merged 4 commits into from
Jan 27, 2024

Conversation

sij1nk
Copy link
Contributor

@sij1nk sij1nk commented Jan 27, 2024

This MR fixes the previously incorrect dispatch string for MoveFocusedWindowToWorkspace(Silent). Since we want to move the window, we want movetoworkspace(silent) instead of workspace here

@yavko
Copy link
Member

yavko commented Jan 27, 2024

This is intended, it's MoveFocusedWindowToWorkspace, MoveToWorkspace exists for what you want

@sij1nk
Copy link
Contributor Author

sij1nk commented Jan 27, 2024

Sorry but I think you misunderstood

Currently MoveFocusedWindowToWorkspace and MoveFocusedWindowToWorkspaceSilent use the workspace dispatcher, which doesn't actually move the focused window - it just changes the workspace

@yavko
Copy link
Member

yavko commented Jan 27, 2024

Sorry but I think you misunderstood

Currently MoveFocusedWindowToWorkspace and MoveFocusedWindowToWorkspaceSilent use the workspace dispatcher, which doesn't actually move the focused window - it just changes the workspace

You're right, but if I'm reading this right you aren't doing it that way if that's the case, you have to get rid of the parameter and the {sep}{work} in the format string.

@yavko
Copy link
Member

yavko commented Jan 27, 2024 •
edited

Sorry but I think you misunderstood
Currently MoveFocusedWindowToWorkspace and MoveFocusedWindowToWorkspaceSilent use the workspace dispatcher, which doesn't actually move the focused window - it just changes the workspace

You're right, but if I'm reading this right you aren't doing it that way if that's the case, you have to get rid of the parameter and the {sep}{work} in the format string.

nvm i read it wrong, ur right

yavko
yavko previously approved these changes Jan 27, 2024
View reviewed changes
Copy link
Member

@yavko yavko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/dispatch.rs Show resolved Hide resolved
@sij1nk
Remove MoveFocusedWindowToWorkspace ...
5d8703e 
... as it's the same as MoveToWorkspace(ws, None), and there is no
reason to keep both
@yavko yavko merged commit 8a1bbdf into hyprland-community:master Jan 27, 2024
3 checks passed
@sij1nk sij1nk deleted the fix/move-focused-window-to-workspace-dispatch-str branch January 28, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yavko yavko yavko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sij1nk @yavko