Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed movetoworkspace and movetoworkspacesilent #49

Merged
merged 2 commits into from
May 28, 2023

Conversation

levnikmyskin
Copy link

Hi!
the movetoworkspace and movetoworkspacesilent were not properly working with special workspaces. This should fix it now.

Please notice I didn't check if there were other broken dispatchers.

Cheers :)

Copy link
Member

@yavko yavko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just could you add support for binds? This function is also used in config::binds::Binder::gen_str :)

src/dispatch.rs Outdated Show resolved Hide resolved
src/dispatch.rs Outdated Show resolved Hide resolved
src/dispatch.rs Outdated Show resolved Hide resolved
src/dispatch.rs Outdated Show resolved Hide resolved
@levnikmyskin
Copy link
Author

Yeah sure, but I don't know how sep works here. From line 467:
let sep = if dispatch { " " } else { "," };

Does this mean sep would be a white space here? because if so, then this wouldn't work.

@yavko
Copy link
Member

yavko commented May 14, 2023

Yeah sure, but I don't know how sep works here. From line 467: let sep = if dispatch { " " } else { "," };

Does this mean sep would be a white space here? because if so, then this wouldn't work.

just add it between here :)
image

@levnikmyskin
Copy link
Author

Hey, sorry for the delay. Been pretty busy. Should be fine now, right?

Copy link
Member

@yavko yavko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yavko yavko merged commit ac79017 into hyprland-community:master May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants