Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] magnify: cannot zoom #105

Closed
dafitt opened this issue May 23, 2024 · 8 comments
Closed

[BUG] magnify: cannot zoom #105

dafitt opened this issue May 23, 2024 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@dafitt
Copy link

dafitt commented May 23, 2024

Pyprland version
Which version did you use?
Pyprland 2.3.2
Hyprland v0.40.0

Describe the bug
I cannot magnify my hyprland deskotp.
Systemd error: FAILED b'config option <misc:cursor_zoom_factor> does not exist.'
I think because hyprland has changed the option misc:cursor_zoom_factor to cursor:zoom_factor in v0.40.0

To Reproduce
Steps to reproduce the behavior:

  1. systemctl start --user pyprland.service
  2. pypr zoom
  3. systemctl status --user pyprland.service
  4. See error FAILED b'config option <misc:cursor_zoom_factor> does not exist.'

Expected behavior
pypr zoom ++0.5 should magnify my desktop.

Configuration (provide following files/samples when relevant):

pyprland.toml:

[pyprland]
plugins = ["magnify"]
@dafitt dafitt added the bug Something isn't working label May 23, 2024
@fdev31
Copy link
Collaborator

fdev31 commented May 23, 2024

Use version 0.40.0 of Hyprland to avoid this issue.
The change only happens in git version.
Looks like it also moved from "misc" to "cursor", I'll try to implement some auto-detection to avoid problems when 0.41 is released, thank you for the report :)

To understand what's going on I checked:

fdev31 added a commit that referenced this issue May 23, 2024
@fdev31
Copy link
Collaborator

fdev31 commented May 23, 2024

Are you able to test with your former setup (in case you changed to stable Hyprland) and also use the git version of Pyprland?
It should be fixed in the latest git version.

@fdev31
Copy link
Collaborator

fdev31 commented May 23, 2024

I installed the git version for testing... and faced another challenge calling hyprctl version -j :

{
    "branch": "main",
    "commit": "4e42107d25dc47ee94da282db233f85f1e4c6bd0",
    "dirty": false,
    "commit_message": "pointermgr: ensure compositor exist on destroy (6216)",
    "commit_date": "Thu May 23 21:19:14 2024",
    "tag": "v0.40.0-127-g4e42107d",
    "commits": "4733",
    "flags": []
}

Current Pypr code considers this is version 0.40.0.... while it broke compatibility for it.
Are you also using arch / using the same package types? If not, what is the output of this command on your setup?

EDIT: I'm thinking in adding a "force_hyprland_version" configuration option for people playing with bleeding edge/unstable versions... but maybe there is a better way.

@fdev31
Copy link
Collaborator

fdev31 commented May 23, 2024

I'm going to add support for hyprland_version in the [pyprland] section, eg:

[pyprland]
include = ["~/.config/hypr/pyprland.d"]
hyprland_version = "0.41.0"

I consider it fixed since I can't find a better solution for those transitioning periods... if you have another (better?) suggestion please re-open.

@fdev31 fdev31 closed this as completed in 5106b84 May 23, 2024
@fdev31
Copy link
Collaborator

fdev31 commented May 23, 2024

Need to write docs, also improved things, maybe you'll not need the hyprland_version config option...

@fdev31 fdev31 reopened this May 23, 2024
@dafitt
Copy link
Author

dafitt commented May 24, 2024

Are you able to test with your former setup (in case you changed to stable Hyprland) and also use the git version of Pyprland?
It should be fixed in the latest git version.

Yes. I am on NixOS and I added pyprland.url = "github:hyprland-community/pyprland"; in flake.nix and an overlay pyprland = inputs.pyprland.packages.${prev.system}.pyprland;, rebuilt and

Confirmed that magnify is working again!


Are you also using arch / using the same package types? If not, what is the output of this command on your setup?

Regarding hyprctl version -j my output is

{
    "branch": "",
    "commit": "2ccd45a84475fab46c6fecd2fe226d3173104743",
    "dirty": true,
    "commit_message": "",
    "commit_date": "2024-05-12",
    "tag": "",
    "commits": "",
    "flags": []
}

which seems broken. I think I have read somewhere that this is a bug only on NixOS but I cannot find the hyprctl issue anymore. But I am currently using the hyprland version on nixpkgs-unstable: 0.40.0-unstable-2024-05-12

@dafitt
Copy link
Author

dafitt commented May 24, 2024

I consider it fixed since I can't find a better solution for those transitioning periods... if you have another (better?) suggestion please re-open.

Sorry, I cannot really help you with that. I'm still a programming newbie.

@fdev31
Copy link
Collaborator

fdev31 commented May 24, 2024

Released a new version including it and added a note in the Troubleshooting page!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants