Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master layout unwanted gap between master and client on vertical bar #1171

Closed
rezaamashi opened this issue Dec 4, 2022 · 3 comments · Fixed by #1260
Closed

Master layout unwanted gap between master and client on vertical bar #1171

rezaamashi opened this issue Dec 4, 2022 · 3 comments · Fixed by #1260
Labels
bug Something isn't working

Comments

@rezaamashi
Copy link

rezaamashi commented Dec 4, 2022

Steps to Reproduce

  1. Enable master layout by running hyprctl keyword general:layout master, or enabling it in hyprland.conf:
general {
   layout=master
}
  1. Set up and enable vertical bar with "exclusive" zone from compositor option ON. In my case, I tried eww and waybar with both resulting the same bug.

  2. The vertical bar could be on either left or right side of the screen

  3. Open master and stacks clients

  4. Observe the gap between master and stacks

Expected Outcome

  1. No gap increase between master and stacks
  2. The client not pushed far to the right

Noted Outcome

  1. Extra gap space between master and stacks (probably Hyprland regard it as an exclusive zone)
  2. Stack pushed far to the right
    • When the bar is on the right, the client window is pushed to the bar area
    • When the bar is on the left, the client window is pushed off the screen

Consult the attached video below:

Screencap-2022120483139.mp4
@rezaamashi rezaamashi added the bug Something isn't working label Dec 4, 2022
@proycon
Copy link
Contributor

proycon commented Dec 10, 2022

You might want to check if this persists after #1202 is merged, I think I spotted and fixed this issue (though I didn't explicitly test it with a vertical bar yet).

@rezaamashi
Copy link
Author

rezaamashi commented Dec 12, 2022

Hi, Thanks for the fix and the new feature.
I am using AUR build hyprland-git. I added orientation setting to my hyprland.conf and orientationprev-orientationnext dispatcher to my keybindings. The issue is fixed for master orientation of left, up, and down. But persists on master orientation right.

The attached video below showing when the vertical bar is on the right, But I also tested with the vertical bar on the left and the issue still persists for orientation right.

Screencap-2022121291419_gapsbetweenmasterstackrightorient.mp4

@proycon
Copy link
Contributor

proycon commented Dec 20, 2022

The above PR should fix this issue once merged, tested with various possible combinations now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants