Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow hyprctl instances even when HYPRLAND_INSTANCE_SIGNATURE is unset #4088

Closed
eriedaberrie opened this issue Dec 8, 2023 · 2 comments
Closed
Labels
enhancement New feature or request

Comments

@eriedaberrie
Copy link
Contributor

Description

hyprctl instances doesn't need HYPRLAND_INSTANCE_SIGNATURE at all, and will work perfectly fine if it's set to some random gibberish. However, if it's entirely unset, it doesn't work because hyprctl errors very early on if the instance signature is unset, even if it doesn't actually end up using it. I think it would be nice if hyprctl instances could be used without an instance signature.

@eriedaberrie eriedaberrie added the enhancement New feature or request label Dec 8, 2023
@Lillecarl
Copy link

https://github.com/hyprwm/Hyprland/blob/main/nix/hm-module.nix#L147 This could be simplified into

      for i in $(${pkgs.hyprland}/bin/hyprctl instances -j | jq ".[].instance" -r); do
        HYPRLAND_INSTANCE_SIGNATURE=$i ${hyprlandPackage}/bin/hyprctl reload config-only
      done

Lillecarl pushed a commit to Lillecarl/home-manager that referenced this issue Dec 8, 2023
When using the previous approach I've always gotten errors that I can't
reload config on the .lock file that exists in /tmp when you run a
standard configured hyprland.
This commit improves this by using hyprctl to find instances to reload
instead.
We can remove the HYPRLAND_INSTANCE_SIGNATURE bogus assignment once
hyprwm/Hyprland#4088 is resolved.

A downside with this commit is that the hyprland module now depends on
jq.
@vaxerski
Copy link
Member

vaxerski commented Dec 8, 2023

288f186

@vaxerski vaxerski closed this as completed Dec 8, 2023
Lillecarl pushed a commit to Lillecarl/home-manager that referenced this issue Dec 10, 2023
When using the previous approach I've always gotten errors that I can't
reload config on the .lock file that exists in /tmp when you run a
standard configured hyprland.
This commit improves this by using hyprctl to find instances to reload
instead.
We can remove the HYPRLAND_INSTANCE_SIGNATURE bogus assignment once
hyprwm/Hyprland#4088 is resolved.
rycee pushed a commit to nix-community/home-manager that referenced this issue Dec 14, 2023
When using the previous approach I've always gotten errors that I can't
reload config on the .lock file that exists in /tmp when you run a
standard configured hyprland.

This commit improves this by using hyprctl to find instances to reload
instead.

We can remove the HYPRLAND_INSTANCE_SIGNATURE bogus assignment once
hyprwm/Hyprland#4088 is resolved.

Co-authored-by: Carl Hjerpe <git@hjerpe.xyz>
fufexan pushed a commit to fufexan/home-manager that referenced this issue Feb 24, 2024
When using the previous approach I've always gotten errors that I can't
reload config on the .lock file that exists in /tmp when you run a
standard configured hyprland.

This commit improves this by using hyprctl to find instances to reload
instead.

We can remove the HYPRLAND_INSTANCE_SIGNATURE bogus assignment once
hyprwm/Hyprland#4088 is resolved.

Co-authored-by: Carl Hjerpe <git@hjerpe.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants